Merged
Conversation
We added more host configs recently, and we run all the checks in sequence, so sometimes Flow ends up being the slowest CI job. This splits the job across multiple processes.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: eee874c...32f44b9 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
approved these changes
Feb 10, 2021
| const rendererInfo = inlinedHostConfigs[i]; | ||
| if (rendererInfo.isFlowTyped) { | ||
| await runFlow(rendererInfo.shortName, ['check']); | ||
| console.log(); |
Member
There was a problem hiding this comment.
Accidental?
Suggested change
| console.log(); |
Collaborator
Author
There was a problem hiding this comment.
Was already there, I assume to add spacing
Co-authored-by: Ricky <rickhanlonii@gmail.com>
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
* Parallelize Flow in CI We added more host configs recently, and we run all the checks in sequence, so sometimes Flow ends up being the slowest CI job. This splits the job across multiple processes. * Fix environment variable typo Co-authored-by: Ricky <rickhanlonii@gmail.com> Co-authored-by: Ricky <rickhanlonii@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added more host configs recently, and we run all the checks in sequence, so sometimes Flow ends up being the slowest CI job.
This splits the job across multiple processes.